PMM-11079 Remove Integrated Alerting #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v3 #2309 +/- ##
==========================================
+ Coverage 43.97% 44.09% +0.12%
==========================================
Files 362 351 -11
Lines 43252 41136 -2116
==========================================
- Hits 19018 18139 -879
+ Misses 22586 21434 -1152
+ Partials 1648 1563 -85
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
artemgavrilov
requested review from
a team,
BupycHuk and
ademidoff
as code owners
artemgavrilov
commented
Jun 30, 2023
|
I believe there could be more mentions of pmm/managed/services/errors.go Line 23 in 6e252ec I suggest we update them all 👍 |
ademidoff
reviewed
Jun 30, 2023
idoqo
approved these changes
Jul 3, 2023
|
I removed |
ademidoff
approved these changes
Jul 3, 2023
|
This PR is postponed until PMM v3 |
artemgavrilov
commented
Sep 28, 2023
|
@BupycHuk @ademidoff I think it's ready to be merged. Tests failure is unrelated to these changes. |
BupycHuk
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-11079
Link to the Feature Build: SUBMODULES-3324
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: